[Eike Ahmels]

I am sorry, i thought pdf.js is non-AMD, but they changed it and notified nobody realy well…

I am not good with require.js neither, i realy dont like it atm, not because its bad (i guess its good), but because we are forced to use it on SPO without any notification as well.

Your code is good, i added a little, to make it more consistent and i added a option to define a exports variable for the shim config.

And you need to change a little, so that double dots (or more dots) wont affect files like pdf.worker.js and pdf.js, where only pdf.js gets loaded, because it overrides pdf.worker.js, which gets registered as “pdf” in the shim config.

I guess you dont need my code, its a little messy, because we needed a quick fix, and your solution is more clean and works as great as mine did.

Regards
Eike Ahmels

[Eike Ahmels]

I fixed it like 2 seconds after i made the post.

You are loading non-AMD js correct. The main problem was the pdf.js, it got changed to a AMD js and is registering itself but removes the global PDFJS variable.
Thats why i cant get it to work. I got it to work with require([“module”], …) stuff. I tried that before, but i missed the correct module name, which i found out now.

Regards
Eike Ahmels

[Eike Ahmels]

Nice to hear that 🙂 good work!
I will look into it, when its ready, feel free to let me test a beta version in our environment.

Regards
Eike

[Eike Ahmels]

Hello Alexander,

its every file that so big, that the loading time of that file is long enough, that require.js is loaded meanwhile.

Yes sure i will send it to you via mail.

Regards
Eike

[Eike Ahmels]

Hello Alexander,

every js file that loads a little longer has problems. This must be, because require.js isnt loaded right away, so it has some delay. When larger libs are loaded, require.js ist loaded before those libs. Smaller libs can be loaded before require.js, i guess thats why.

Regards
Eike

[Eike Ahmels]

Hello Alexander,

yes this works, the main problem is, that it doesnt stop with jquery-ui, no custom js files will load properly, in most cases, 0 customjs files is loaded.
I found out, that the problem is, that when DFFS_loader.html loads its libs, require.js is not loaded. But when DFFS_frontend is loading, requirejs is present and everything fails.
I coded a block, where it checks if its SharePoint Online or not, if it is, the whole customjs files loading procedure is done through requirejs, if not, the main codechain is executed. This works great, but i dont know how far.

Regards
Eike

[Eike Ahmels]

Again 😀

I changed the DFFS_frontend_min.js and DFFS_loader.html, so that it works with SharePoint Online. Its a realy quick and dirty fix i would say, but i would give you the changes, so you can look into it to make it work properly with require.js

Regards
Eike

[Eike Ahmels]

Me again 🙂

I coded a little into the DFFS loader to let it use require.js a little. I hardcoded the plugins we need here into it and it loads and no more errors.

So i guess if its SharePoint Online, you should code around or with require.js.
The problem is, when DFFS_loader.html is called, require.js is not finished loading.

If you need more info, let me know.

Regards
Eike

[Eike Ahmels]

Hello Alexander,

i have a update, i discovered, that i have the same issue with DFFS 4.4.1 on a page which worked 100% before. I guess SharePoint Online changed/updated something. On premise it works so far.

I have no clue why and my investigations came out with nothing so far.

Pretty strange, because the issue just came up on two different sites, where one worked 100% before.

If you need more info, just ask, i guess i can give you some sort of access to the site, so you can see the error your self.

Regards
Eike

[Eike Ahmels]

Hello Alexander,

we are using the latest DFFS build (not beta).

jQuery.fn.jquery = "1.12.4"

I removed the jQuery.noConflict() part to test if this changes anything, but it doesnt. Same error as before, the custom js files are loaded (i can see the script tags in the DOM), but the objects arent present.

Regards
Eike

[Eike Ahmels]

Hi,
thanks for the fast answer!
That fixed the issue.

Any plans on making this feature and dffs working together?

Regards
Eike

[Author]

Posts